Move pft_ping.py and sniffer.py to the common test directory

[ahsanb]

Summary

The pft_ping.py and sniffer.py tool is moved from/tests/sys/netpfil/pf to /tests/sys/netpfil/common directory because these tools are to be used in common for all the firewalls.

[ahsanb]

• Make the pf tests use the sniffer and pft_ping tools from the common directory and hence ensure only one installation of these tools.

[kp]

This probably also wants this:

diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc
index 19adf066b1b..1725b06fa69 100644
--- a/ObsoleteFiles.inc
+++ b/ObsoleteFiles.inc
@@ -38,6 +38,9 @@
 #   xargs -n1 | sort | uniq -d;
 # done

+# 20190816: move common netpfil test files
+OLD_FILES+=usr/tests/sys/netpfil/pf/sniffer.py
+OLD_FILES+=usr/tests/sys/netpfil/pf/pft_ping.py
 # 20190729: gzip'ed a.out support removed
 OLD_FILES+=usr/include/sys/inflate.h
 # 20190722: cap_random(3) removed

That'll allow people to clean up the old version of sniffer.py and pft_ping.py.

tests/sys/netpfil/pf/forward.sh

48 ↗

(On Diff #60873)

I'd do ${common_dir}/pft_ping.py, if only for consistency.

[ahsanb]

• Add old pft_ping and sniffer.py to ObsoleteFiles.inc

[ahsanb]

• replace $common_dir with ${common_dir} for consistency

[ahsanb]

• Fix “replace $common_dir with ${common_dir} for consistency”

[ahsanb]

• Since the NAT tests landed before this diff the merge wouldn't be possible because the NAT tests changed the common/Makefile. Created an updated diff from the new upstream.