Paths

Table of Contentst

Differential D21246

Mk/Uses/go.mk: Add gomod-vendor helper target
ClosedPublic
Actions

Authored by dmgk on Aug 13 2019, 12:42 PM.

Tags

None

Referenced Files

	F82146324: D21246.id.diff
	Thu, Apr 25, 10:44 PM

	F82137757: D21246.id60743.diff
	Thu, Apr 25, 8:50 PM

	F82137755: D21246.id60725.diff
	Thu, Apr 25, 8:50 PM

	Unknown Object (File)
	Thu, Apr 25, 7:15 AM

	Unknown Object (File)
	Thu, Apr 25, 5:35 AM

	Unknown Object (File)
	Wed, Apr 24, 6:42 PM

	Unknown Object (File)
	Wed, Apr 24, 6:40 PM

	Unknown Object (File)
	Wed, Apr 24, 5:53 AM

View All 25 Files

Subscribers

Details

Reviewers

Group Reviewers

O5: Ports Framework	(Owns No Changed Paths)
portmgr

Commits

rP508838: Mk/Uses/go.mk: Add gomod-vendor helper target

Summary

Help port maintainers to automate GH_/GL_TUPLE generation by providing gomod-vendor helper target

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 25834
Build 24406: arc lint + arc unit

Event Timeline

dmgk created this revision.Aug 13 2019, 12:42 PM

Owners added a reviewer: O5: Ports Framework.Aug 13 2019, 12:42 PM

Herald added a reviewer: portmgr. · View Herald TranscriptAug 13 2019, 12:42 PM

Herald added a subscriber: mat. · View Herald Transcript

Harbormaster completed remote builds in B25831: Diff 60722.Aug 13 2019, 12:42 PM

dmgk mentioned this in D21243: Porter's Handbook: Add an example on how to create a USES=go port.Aug 13 2019, 12:43 PM

tobik added inline comments.Aug 13 2019, 12:59 PM

Mk/Uses/go.mk
133	`extract` should be `patch` in case the maintainer decides to patch build files for whatever reason.
138	I think just `Please install ports-mgmt/modules2tuple` would suffice.

Change gomod-vendor target dependency to patch.

Harbormaster completed remote builds in B25833: Diff 60725.Aug 13 2019, 1:02 PM

dmgk marked an inline comment as done.Aug 13 2019, 1:04 PM

dmgk added inline comments.

Mk/Uses/go.mk
133	Ha, just thought about this too.

Update modules2tuple install message wording.

Harbormaster completed remote builds in B25834: Diff 60726.Aug 13 2019, 1:06 PM

dmgk marked an inline comment as done.Aug 13 2019, 1:07 PM

tobik accepted this revision.Aug 13 2019, 3:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 13 2019, 5:23 PM

Closed by commit rP508838: Mk/Uses/go.mk: Add gomod-vendor helper target (authored by tobik). · Explain Why

This revision was automatically updated to reflect the committed changes.

tobik added a commit: rP508838: Mk/Uses/go.mk: Add gomod-vendor helper target.

Revision Contents
Changeset List

Path

Size

Mk/

Uses/

13 lines

Diff 60726

Mk/Uses/go.mk

Loading...