Page MenuHomeFreeBSD

Add another example to USE_GITHUB.
ClosedPublic

Authored by mat on Mar 23 2015, 1:12 PM.

Diff Detail

Repository
rD FreeBSD doc repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mat updated this revision to Diff 4342.Mar 23 2015, 1:12 PM
mat retitled this revision from to Add another example to USE_GITHUB..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added a reviewer: Doc Committers.
mat added a subscriber: portmgr.
bcr added a subscriber: bcr.Mar 23 2015, 1:46 PM

Me, being the king of overlong sentences with huge chains of commas, sees these things in the writing of others, but not in my own. ;-)

en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
1891 ↗(On Diff #4342)

I'd stop the sentence here at the , and start a new one in order not to make the sentence too long.
The paragraph should then be like this:
From time to time ... variation from PORTREVISION. For example, if the version ...

1893 ↗(On Diff #4342)

... and another stop here. The sentence goes from:
For example, if the version ... the tag is v1.0.2. In those cases, it is possible to use DISTVERSIONPREFIX or DISTVERSIONSUFFIX: ...

In D2118#4, @bcr wrote:

Me, being the king of overlong sentences with huge chains of commas, sees these things in the writing of others, but not in my own. ;-)

This is me.

mat updated this revision to Diff 4343.Mar 23 2015, 1:56 PM

Split up the first sentence.

Thanks for documenting this piece!

en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
1833 ↗(On Diff #4342)

I don't believe DISTVERSIONFULL is documented anywhere. I added it to avoid duplication, but it may be overkill. Either need to define DISTVERSIONFULL in the PH or just expand it out here to {DISTVERSIONPREVIX}{DISTVERSION}{DISTVERSIONSUFFIX}

mat updated this revision to Diff 4344.Mar 23 2015, 1:56 PM

And a missed "s".

mat added a comment.EditedMar 23 2015, 1:59 PM
This comment has been deleted.
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
1833 ↗(On Diff #4342)

Yeah, it's not documented anywhere, I started by expanding it here, but then the last column gets a bit big, and I'm sure the pdf version will look aweful. Maybe we don't really care.

mat updated this revision to Diff 4345.Mar 23 2015, 2:07 PM

Expand DISTVERSIONFULL, it does not really exist (c)(r)

bcr added inline comments.Mar 23 2015, 6:12 PM
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
1892 ↗(On Diff #4345)

Add a comma after the word "example", then it is perfect (for me).

mat closed this revision.Mar 23 2015, 6:18 PM
mat updated this revision to Diff 4358.

Closed by commit rD46370 (authored by @mat).