loader.efi: replace HandleProtocol() with OpenProtocol()

[tsoome]

Summary

The HandleProtocol() is deprecated interface and we should use OpenProtocol() instead. Moreover, in some firmware implementation(s), the HandleProtocol() does return device path using static storage, so we can not keep the value returned there. With same firmware, the OpenProtocol() does return data we do not need to clone.

Test Plan

Tested by network and disk boot.

[imp]

love the idea, but think it would be better to create a centralized location where we wrap this.
Call me paranoid, but I fear there may be a EFI bios we need to do this for :(
But also, it will make the code easier to read, so win/win.

stand/efi/boot1/proto.c

64 ↗

(On Diff #60452)

maybe we should create wrappers for this stuff to make it less verbose everywhere we use it.

[tsoome]

In D21162#459738, @imp wrote:

love the idea, but think it would be better to create a centralized location where we wrap this.
Call me paranoid, but I fear there may be a EFI bios we need to do this for :(
But also, it will make the code easier to read, so win/win.

hm, I got some idea about it, I'll think a bit...

[tsoome]

Implement OpenProtocolByHandle()