devel/libevent2: update to 2.1.11
ClosedPublic
Actions

Authored by jbeich on Aug 2 2019, 12:50 PM.

Details

Reviewers

zeising

Commits

rP507877: devel/libevent2: update to 2.1.11

Summary

https://github.com/libevent/libevent/releases/tag/release-2.1.11-stable

IMPORTANT: Don't land together with unrelated changes to avoid mixing in regressions.

Test Plan

"poudriere bulk -t" passed:

11.2 aarch64/amd64/armv6/i386
11.3 amd64/i386
12.0 aarch64/amd64/armv6/armv7/i386
13.0 amd64/armv6/armv7/i386
OPENSSL=off THREADS=off (on 11.2 i386)
DEFAULT_VERSIONS += ssl=libressl (on 11.2 amd64)
DEFAULT_VERSIONS += ssl=libressl-devel (on 11.2 amd64)
DEFAULT_VERSIONS += ssl=openssl (on 12.0 amd64)
DEFAULT_VERSIONS += ssl=openssl111 (on 11.2 amd64)
All consumers (including non-default) built fine on 11.2 amd64

Runtime works fine:

net-p2p/transmission-daemon
security/tor
sysutils/tmux
www/firefox

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 25639
Build 24232: arc lint + arc unit

Event Timeline

jbeich created this revision.Aug 2 2019, 12:50 PM

Herald added a subscriber: andrew. · View Herald TranscriptAug 2 2019, 12:50 PM

Harbormaster completed remote builds in B25639: Diff 60385.Aug 2 2019, 12:50 PM

lgtm (I only glanced at the patch, and haven't tested it, though).

This revision is now accepted and ready to land.Aug 2 2019, 1:00 PM

jbeich added inline comments.Aug 2 2019, 1:01 PM

lang/crystal/Makefile
5	Oops, one more place to adjust whitespace after Tools/scripts/bump-revision.sh

Whitespace

This revision now requires review to proceed.Aug 2 2019, 1:03 PM

Harbormaster completed remote builds in B25640: Diff 60387.Aug 2 2019, 1:03 PM

Minor nits, I noticed them, but feel free to change or leave them as-is.

security/tor-devel/Makefile
7	Nit-picking, but since I saw it. Perhaps leave PORTREVISION at the same line it was previously, to make the diff clearer. I don't think it's that important though.
www/envoy/Makefile
7	Same here, with the PORTREVISION changing lines.
www/nghttp2/Makefile
7	And here

zeising accepted this revision.Aug 2 2019, 1:07 PM

This revision is now accepted and ready to land.Aug 2 2019, 1:07 PM

jbeich added inline comments.Aug 2 2019, 1:20 PM

security/tor-devel/Makefile

Doing so would break style:

$ portlint -C
FATAL: Makefile: DISTVERSIONSUFFIX appears out-of-order.
FATAL: Makefile: order must be PORTNAME/PORTVERSION/DISTVERSIONPREFIX/DISTVERSION/DISTVERSIONSUFFIX/PORTREVISION/P
ORTEPOCH/CATEGORIES/MASTER_SITES/MASTER_SITE_SUBDIR/PROJECTHOST/PKGNAMEPREFIX/PKGNAMESUFFIX/DISTNAME/EXTRACT_SUFX/DISTFILES/DIST_SUBDIR/EXTRACT_ONLY.

zeising added inline comments.Aug 2 2019, 1:24 PM

security/tor-devel/Makefile
7	I'm aware, however, fixing style and bumping portrevision in the same commit isn't great. I thought it would be clearer to leave it at the same line, but I'll leave it to you to decide.

Closed by commit rP507877: devel/libevent2: update to 2.1.11 (authored by jbeich). · Explain WhyAug 2 2019, 1:31 PM

This revision was automatically updated to reflect the committed changes.

jbeich added a commit: rP507877: devel/libevent2: update to 2.1.11.

jbeich added inline comments.Aug 2 2019, 1:54 PM

security/tor-devel/Makefile
7	That would introduce too much churn. Tools/scripts/bump-revision.sh is what routinely breaks style. And I only fixed style in the lines that had to be changed. The style in question existed for years and was never questioned (to my recollection) unlike the recent silliness in having a newline after `USES`.