Page MenuHomeFreeBSD

Change autounmountd(8) to use time_t for duration instead of double
ClosedPublic

Authored by jhibbits on Jul 30 2019, 2:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 7:43 PM
Unknown Object (File)
Nov 5 2024, 3:22 PM
Unknown Object (File)
Oct 6 2024, 3:25 AM
Unknown Object (File)
Sep 27 2024, 1:19 PM
Unknown Object (File)
Sep 20 2024, 10:41 PM
Unknown Object (File)
Sep 20 2024, 10:41 PM
Unknown Object (File)
Sep 20 2024, 10:41 PM
Unknown Object (File)
Sep 20 2024, 10:30 PM
Subscribers

Details

Summary

autounmountd(8) uses doubles to handle mount time durations. However,
it must convert to integer types, time_t in particular, to do anything
meaningful. Additionally, even though it's a floating-point value in
seconds, the sub-seconds component is never used, so it's unnecessary.

Switching type to time_t fixes an assertion on powerpc64, which checks
that a sleep value that's not -1.0 is greater than 0. On powerpc64, it
happens that the value of -1.0 gets loaded as a float (perhaps a bug in
gcc), but gets compared to a double. This compares as false, so follows
through the 'sleep != -1.0' path, and fails the assert. Since the
sub-second component isn't used in the double, just drop it and deal
with whole-integer seconds.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 25582
Build 24185: arc lint + arc unit