Page MenuHomeFreeBSD
Differential D21074

sfxge(4): fix power of 2 round up when align has smaller type
ClosedPublic
Actions

Authored by arybchik on Jul 26 2019, 3:02 PM.
Tags
None
Referenced Files
F133534247: D21074.id60187.diff
Sun, Oct 26, 11:44 AM
F133502726: D21074.id.diff
Sun, Oct 26, 6:25 AM
Unknown Object (File)
Sun, Oct 26, 3:34 AM
Unknown Object (File)
Sun, Oct 26, 2:20 AM
Unknown Object (File)
Sun, Oct 26, 1:07 AM
Unknown Object (File)
Sat, Oct 25, 11:41 PM
Unknown Object (File)
Sat, Oct 25, 12:06 PM
Unknown Object (File)
Fri, Oct 17, 8:16 AM
View All 98 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS350369: sfxge(4): fix power of 2 round up when align has smaller type
Summary

Substitute driver-defined P2ROUNDUP() h with EFX_P2ROUNDUP()
defined in libefx.

Cast value and alignment to one specified type to guarantee result
correctness.

Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

amd64 tinderbox build tested

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25515
Build 24133: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
9 lines
3 lines
5 lines
4 lines
13 lines
9 lines
4 lines
3 lines
7 lines

Diff 60164

View Options

sys/dev/sfxge/common/ef10_impl.h

Loading...
View Options

sys/dev/sfxge/common/ef10_nvram.c

Loading...
View Options

sys/dev/sfxge/common/ef10_rx.c

Loading...
View Options

sys/dev/sfxge/common/efsys.h

Loading...
View Options

sys/dev/sfxge/common/efx.h

Loading...
View Options

sys/dev/sfxge/common/efx_mcdi.h

Loading...
View Options

sys/dev/sfxge/common/efx_tx.c

Loading...
View Options

sys/dev/sfxge/sfxge_port.c

Loading...
View Options

sys/dev/sfxge/sfxge_rx.c

Loading...