Page MenuHomeFreeBSD
Differential D21074

sfxge(4): fix power of 2 round up when align has smaller type
ClosedPublic
Actions

Authored by arybchik on Jul 26 2019, 3:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 9, 10:07 PM
Unknown Object (File)
Fri, Mar 6, 7:58 AM
Unknown Object (File)
Sat, Feb 28, 10:15 AM
Unknown Object (File)
Sat, Feb 28, 6:43 AM
Unknown Object (File)
Thu, Feb 12, 2:22 PM
Unknown Object (File)
Feb 9 2026, 11:05 AM
Unknown Object (File)
Dec 23 2025, 5:03 AM
Unknown Object (File)
Dec 14 2025, 7:22 AM
View All Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS350369: sfxge(4): fix power of 2 round up when align has smaller type
Summary

Substitute driver-defined P2ROUNDUP() h with EFX_P2ROUNDUP()
defined in libefx.

Cast value and alignment to one specified type to guarantee result
correctness.

Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

Test Plan

amd64 tinderbox build tested

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
common/
9 lines
3 lines
5 lines
4 lines
13 lines
9 lines
4 lines
3 lines
7 lines

Diff 60187

View Options

head/sys/dev/sfxge/common/ef10_impl.h

Loading...
View Options

head/sys/dev/sfxge/common/ef10_nvram.c

Loading...
View Options

head/sys/dev/sfxge/common/ef10_rx.c

Loading...
View Options

head/sys/dev/sfxge/common/efsys.h

Loading...
View Options

head/sys/dev/sfxge/common/efx.h

Loading...
View Options

head/sys/dev/sfxge/common/efx_mcdi.h

Loading...
View Options

head/sys/dev/sfxge/common/efx_tx.c

Loading...
View Options

head/sys/dev/sfxge/sfxge_port.c

Loading...
View Options

head/sys/dev/sfxge/sfxge_rx.c

Loading...