games/lwjgl: update to latest snapshot

[voidanix_420blaze.it]

Summary

This is also considered "legacy" now that lwjgl3 has been out for some time

Switch to GH as well

[voidanix_420blaze.it]

Use correct year (one shall not do PRs at 2AM)

[lwhsu]

https://bugs.freebsd.org/239415

[lwhsu]

I seems cannot be applied cleanly. Could you help to rebase this patch? Thanks!

[voidanix_420blaze.it]

Rebase diff, while here remove the hardcoded version from other ports

[voidanix_420blaze.it]

Unbreak on i386 by allowing relocations on read-only segments

[lwhsu]

This one generally looks and tested good. I'll check some minor stuffs and commit.

[lwhsu]

games/lwjgl/Makefile

1

Please don't remove created by header unless having approval of that person.

5

I suggest have a DISTVERSION as porter's handbook suggests. Please the last paragraph of:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-naming.html#makefile-portepoch

games/minecraft-client/files/minecraft-runtime

3 ↗

(On Diff #65468)

We need to bump PORTREVISION for this change.

games/multimc/Makefile

30 ↗

(On Diff #65468)

We need to bump PORTREVISION for this change.

[voidanix_420blaze.it]

Keep author (meant to have $FreeBSD$, oops), fix naming and bump ports touched by the patch

[lwhsu]

Just a very minor nit. I can modify it when committing if you're OK with it.

Thanks for your work!

games/lwjgl/Makefile

5

$ pkg version -t 2.9.3 2.9.3.20161208
<

I guess 2.9.3.20161208 is enough?

[voidanix_420blaze.it]

games/lwjgl/Makefile

5

The version has been bumped to 2.9.4 since January 2015

You can see that here; the deprecation notice has been added later so I guess it's safe to keep it like this

[lwhsu]

games/lwjgl/Makefile

5

I see. Normally it will cause problem when 2.9.4 release (because 2.9.4 < 2.9.4.20161208), but since it's deprecated and will unlikely have new release, I think it's fine.

[lwhsu]

games/lwjgl/Makefile

45

Sorry, one more question, what's the reason of this s/%%JAVAJARDIR%%/${JAVAJARDIR}/ change?

[voidanix_420blaze.it]

games/lwjgl/Makefile

45

portlint doesn't really like this:
FATAL: PLIST_FILES: files cannot contain %%FOO%% variables. Use make variables and logic instead