Page MenuHomeFreeBSD

games/lwjgl: update to latest snapshot
ClosedPublic

Authored by voidanix_420blaze.it on Jul 23 2019, 11:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 11:59 AM
Unknown Object (File)
Mon, Dec 2, 1:42 PM
Unknown Object (File)
Nov 22 2024, 12:23 PM
Unknown Object (File)
Nov 22 2024, 1:19 AM
Unknown Object (File)
Nov 18 2024, 8:01 PM
Unknown Object (File)
Nov 16 2024, 6:26 PM
Unknown Object (File)
Nov 6 2024, 3:27 PM
Unknown Object (File)
Nov 1 2024, 3:16 PM

Details

Summary

This is also considered "legacy" now that lwjgl3 has been out for some time

Switch to GH as well

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Use correct year (one shall not do PRs at 2AM)

lwhsu requested changes to this revision.Dec 8 2019, 3:19 PM

I seems cannot be applied cleanly. Could you help to rebase this patch? Thanks!

This revision now requires changes to proceed.Dec 8 2019, 3:19 PM

Rebase diff, while here remove the hardcoded version from other ports

Unbreak on i386 by allowing relocations on read-only segments

This one generally looks and tested good. I'll check some minor stuffs and commit.

This revision is now accepted and ready to land.Dec 10 2019, 8:06 PM
games/lwjgl/Makefile
1 ↗(On Diff #65468)

Please don't remove created by header unless having approval of that person.

4 ↗(On Diff #65468)

I suggest have a DISTVERSION as porter's handbook suggests. Please the last paragraph of:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-naming.html#makefile-portepoch

games/minecraft-client/files/minecraft-runtime
3 ↗(On Diff #65468)

We need to bump PORTREVISION for this change.

games/multimc/Makefile
30 ↗(On Diff #65468)

We need to bump PORTREVISION for this change.

Keep author (meant to have $FreeBSD$, oops), fix naming and bump ports touched by the patch

This revision now requires review to proceed.Dec 10 2019, 9:32 PM

Just a very minor nit. I can modify it when committing if you're OK with it.

Thanks for your work!

games/lwjgl/Makefile
4 ↗(On Diff #65468)
$ pkg version -t 2.9.3 2.9.3.20161208
<

I guess 2.9.3.20161208 is enough?

This revision is now accepted and ready to land.Dec 10 2019, 9:40 PM
games/lwjgl/Makefile
4 ↗(On Diff #65468)

The version has been bumped to 2.9.4 since January 2015

You can see that here; the deprecation notice has been added later so I guess it's safe to keep it like this

games/lwjgl/Makefile
4 ↗(On Diff #65468)

I see. Normally it will cause problem when 2.9.4 release (because 2.9.4 < 2.9.4.20161208), but since it's deprecated and will unlikely have new release, I think it's fine.

games/lwjgl/Makefile
36 ↗(On Diff #65474)

Sorry, one more question, what's the reason of this s/%%JAVAJARDIR%%/${JAVAJARDIR}/ change?

games/lwjgl/Makefile
36 ↗(On Diff #65474)

portlint doesn't really like this:
FATAL: PLIST_FILES: files cannot contain %%FOO%% variables. Use make variables and logic instead

This revision was automatically updated to reflect the committed changes.