Page MenuHomeFreeBSD

games/lwjgl: update to latest snapshot

Authored by on Jul 23 2019, 11:26 PM.
Referenced Files
Unknown Object (File)
Tue, Nov 28, 11:56 AM
Unknown Object (File)
Sat, Nov 25, 8:48 PM
Unknown Object (File)
Thu, Nov 23, 11:46 PM
Unknown Object (File)
Wed, Nov 15, 5:55 AM
Unknown Object (File)
Wed, Nov 15, 5:18 AM
Unknown Object (File)
Tue, Nov 14, 1:00 AM
Unknown Object (File)
Sun, Nov 12, 8:48 AM
Unknown Object (File)
Fri, Nov 10, 11:03 AM



This is also considered "legacy" now that lwjgl3 has been out for some time

Switch to GH as well

Diff Detail

rP FreeBSD ports repository
Lint Not Applicable
Tests Not Applicable

Event Timeline

Use correct year (one shall not do PRs at 2AM)

lwhsu requested changes to this revision.Dec 8 2019, 3:19 PM

I seems cannot be applied cleanly. Could you help to rebase this patch? Thanks!

This revision now requires changes to proceed.Dec 8 2019, 3:19 PM

Rebase diff, while here remove the hardcoded version from other ports

Unbreak on i386 by allowing relocations on read-only segments

This one generally looks and tested good. I'll check some minor stuffs and commit.

This revision is now accepted and ready to land.Dec 10 2019, 8:06 PM
1 ↗(On Diff #65468)

Please don't remove created by header unless having approval of that person.

4 ↗(On Diff #65468)

I suggest have a DISTVERSION as porter's handbook suggests. Please the last paragraph of:

3 ↗(On Diff #65468)

We need to bump PORTREVISION for this change.

30 ↗(On Diff #65468)

We need to bump PORTREVISION for this change.

Keep author (meant to have $FreeBSD$, oops), fix naming and bump ports touched by the patch

This revision now requires review to proceed.Dec 10 2019, 9:32 PM

Just a very minor nit. I can modify it when committing if you're OK with it.

Thanks for your work!

4 ↗(On Diff #65468)
$ pkg version -t 2.9.3

I guess is enough?

This revision is now accepted and ready to land.Dec 10 2019, 9:40 PM
4 ↗(On Diff #65468)

The version has been bumped to 2.9.4 since January 2015

You can see that here; the deprecation notice has been added later so I guess it's safe to keep it like this

4 ↗(On Diff #65468)

I see. Normally it will cause problem when 2.9.4 release (because 2.9.4 <, but since it's deprecated and will unlikely have new release, I think it's fine.

36 ↗(On Diff #65474)

Sorry, one more question, what's the reason of this s/%%JAVAJARDIR%%/${JAVAJARDIR}/ change?

36 ↗(On Diff #65474)

portlint doesn't really like this:
FATAL: PLIST_FILES: files cannot contain %%FOO%% variables. Use make variables and logic instead

This revision was automatically updated to reflect the committed changes.