Differential D2103

GH_TAGNAME in the DISTNAME if set for new USE_GITHUB.
ClosedPublic
Actions

Authored by bdrewery on Mar 20 2015, 6:18 PM.

Details

Reviewers

None

Group Reviewers

portmgr

Commits

rP381777: For the new USE_GITHUB with only GH_TAGNAME set default DISTNAME to

Summary

I noticed while updating poudriere-devel today that if I were to release
a 2nd update for today and use the same PORTVERSION of 20150320 and only
bump the GH_TAGNAME to a new hash and PORTREVISION that the DISTNAME
would remain the same. I had previously worked around this by defining
my own DISTNAME in the port to include GH_COMMIT/GH_TAGNAME.

This previously bit me on a portmaster update as well before I overrode
DISTNAME in that port in rP320240.

I think this same change should be made global.

All affected ports are updated. My and mat's mirrors would need to be updated
again.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bdrewery updated this revision to Diff 4305.Mar 20 2015, 6:18 PM

bdrewery retitled this revision from to Include GH_ACCOUNT/GH_PROJECT/GH_TAGNAME in the DISTNAME if set for new USE_GITHUB..

bdrewery updated this object.

bdrewery edited the test plan for this revision. (Show Details)

bdrewery added a reviewer: portmgr.

bdrewery added a subscriber: mat.

Herald edited edge metadata. · View Herald TranscriptMar 20 2015, 6:18 PM

My summary may not be clear, this also fixes if a project moves to a new GH_ACCOUNT. The distfile would conflict and cause a bad checksum without having it in the DISTNAME.