Avoid copying too much from the input string.
ClosedPublic
Actions

Authored by brooks on Jul 19 2019, 10:47 PM.

Details

Reviewers

ngie
asomers

Commits

rS350539: MFC r350160:
rS350526: MFC r350160:
rS350160: Avoid copying too much from the input string.

Summary

This avoids reading past the end of the static strings. On a system
with bounds checking these tests fault.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Jul 19 2019, 10:47 PM

Harbormaster completed remote builds in B25435: Diff 59950.Jul 19 2019, 10:48 PM

LGTM. But in the commit message, change "One a system" to "On a system".

This revision is now accepted and ready to land.Jul 19 2019, 11:09 PM

brooks edited the summary of this revision. (Show Details)Jul 19 2019, 11:15 PM

jacob.e.keller_intel.com mentioned this in D21005: iflib: add iflib_deregister to help cleanup on exit.Jul 19 2019, 11:53 PM

Closed by commit rS350160: Avoid copying too much from the input string. (authored by brooks). · Explain WhyJul 19 2019, 11:58 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS350160: Avoid copying too much from the input string..

Herald added a subscriber: imp. · View Herald TranscriptJul 19 2019, 11:58 PM

brooks added a commit: rS350526: MFC r350160:.Aug 1 2019, 11:29 PM

brooks added a commit: rS350539: MFC r350160:.Aug 2 2019, 4:05 PM

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

tests/

string/

wcsnlen_test.c

2 lines

Diff 59954

View Options

head/lib/libc/tests/string/wcsnlen_test.c

Avoid copying too much from the input string.ClosedPublicActions