Increase YPMAXRECORD to 16M to be compatible with Linux.

[kib]

Summary

Glibc made same change, increasing the allowed length for keys and values in YP to 16M, in 2013. We need this for compatibility with very large automounter maps.

Since YP protocol definition uses the constant to declare variable-size opaque byte strings, the change should be binary compatible with existing installations which do not expose keys or values larger than 1024 bytes.

All uses of local variables with YPMAXRECORD sizes were removed to avoid insane stack use. On the other hand, variables with static lifetime should be fine and only result in increased VA use.

Sponsored by: Mellanox Technologies

[kib]

Accumulated bugfixes.

[• ian]

lib/libc/net/gethostbynis.c

92 ↗

(On Diff #59596)

s/&ypbuf/ypbuf/

same change a few lines down in result= line

lib/libc/net/getnetbynis.c

81 ↗

(On Diff #59596)

&ypbuf here and 3 lines down as well

In fact, it looks like this pattern of the old code using '&array' instead of just 'array' is repeated in more of the changes below, I'm not going to flag every one of them right now (because I was just doing a "quick glance" and have to get back to $work).

[kib]

Fix bugs pointed out by ian. I did not found other instances of it.

[markj]

usr.sbin/rpc.yppasswdd/yppasswdd_server.c

368 ↗

(On Diff #60538)

Should this be a goto as well?

[kib]

Do not leak pwbuf.

[markj]

There are no checks for memory allocation failures, but otherwise it looks ok to me.

[kib]

Add checks for ENOMEM.

[markj]

usr.sbin/yppush/yppush_main.c

448 ↗

(On Diff #60581)

return YP_YPERR?

[kib]

usr.sbin/yppush/yppush_main.c

448 ↗

(On Diff #60581)

I am not sure.

I returned 0 on principle that malloc might fail mostly due to insane size, not because app should handle real OOM situation. And then, returning 0 means that the iteration over the entries should continue, which is what I believe is the right action.

[markj]

usr.sbin/yppush/yppush_main.c

448 ↗

(On Diff #60581)

Ok. It might be worth a comment.

[kib]

Add comment hinting why we do not stop iteration on asprintf (malloc) failure.