sfxge: assert either kernel or internal copy of interface flags

[arybchik]

Summary

ioctl to put interface down sets ifp->if_flags which holds the intended
administratively defined state and calls driver callback to apply it.
When everything is done, driver updates internal copy of
interface flags sc->if_flags which holds the operational state.
So, transmit from Rx path is possible when interface is intended to be
administratively down in accordance with ifp->if_flags, but not applied
yet and the operational state is up in accordance with sc->if_flags.

Sponsored by: Solarflare Communications, Inc.

Test Plan

Module build tested.
Driver tested with invariants.
Interface up/down tested under traffic.
Interface is tested as port in link aggregation.

[gnn]

Why is this an assert rather than an error return?

[arybchik]

It is an extra conditional. The check exists and packets are dropped when deferred packet list is served.
Assert is useful to double-check driver prerequisites.

[arybchik]

Closed by commit rS280374 (authored by @arybchik).