Differential D20741

Remove references to splbio().
ClosedPublic
Actions

Authored by markj on Jun 24 2019, 4:29 PM.

Details

Reviewers

kib
mckusick

Commits

rS349419: Remove references to splbio in ffs_softdep.c.

Summary

In ffs_softdep.c, various dependency completion routines are documented as blocking splbio.
In smbfs we don't need splbio to modify the buf, which must be locked.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jun 24 2019, 4:29 PM

Harbormaster completed remote builds in B25004: Diff 58953.Jun 24 2019, 4:29 PM

markj added reviewers: kib, mckusick.Jun 24 2019, 4:29 PM

kib added inline comments.Jun 24 2019, 6:31 PM

sys/ufs/ffs/ffs_softdep.c
2113 ↗	(On Diff #58953)	I think in modern times this sentence could be replaced with the statement that the function can sleep.
8882 ↗	(On Diff #58953)	There (and in other similar places) it probably would be useful to say that SU mp lock should be owned, but it repeated by the assert at line 8896.

I suggest you to go ahead with smbfs part.

markj added inline comments.Jun 24 2019, 7:37 PM

sys/ufs/ffs/ffs_softdep.c
2113 ↗	(On Diff #58953)	Well, the sleep can occur only if DEPALLOC is passed. Do you think it is worth documenting these constraints?
8882 ↗	(On Diff #58953)	Indeed, and there are many functions which assert this lock.

Simply deleting the comments about splbio is fine. It might be helpful to change the comment to say `Called with the soft update lock held.' In many places the lock ownership is asserted which may be sufficient, or perhaps the assertion should be added where it is not already there.

This revision is now accepted and ready to land.Jun 24 2019, 11:42 PM