Page MenuHomeFreeBSD
Differential D20736

The porter's handbook Go chapter: document no_targets/run args and GO_PORT variable
ClosedPublic
Actions

Authored by dmgk on Jun 24 2019, 4:21 PM.
Tags
None
Referenced Files
F134421343: D20736.id59185.diff
Sun, Nov 2, 3:23 AM
Unknown Object (File)
Wed, Oct 29, 2:45 PM
Unknown Object (File)
Wed, Oct 29, 6:17 AM
Unknown Object (File)
Tue, Oct 28, 8:21 PM
Unknown Object (File)
Tue, Oct 28, 7:43 PM
Unknown Object (File)
Tue, Oct 28, 2:37 AM
Unknown Object (File)
Tue, Oct 28, 12:24 AM
Unknown Object (File)
Mon, Oct 27, 7:33 PM
View All Files
Subscribers
None

Details

Reviewers
mat
tobik
swills
jlaffaye
Commits
rD53205: Porter's Handbook: Document no_targets/run and GO_PORT after ports r505321

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 25052
Build 23765: arc lint + arc unit

Event Timeline

dmgk created this revision.Jun 24 2019, 4:21 PM
Herald added a reviewer: mat. · View Herald TranscriptJun 24 2019, 4:21 PM
Harbormaster completed remote builds in B24999: Diff 58948.Jun 24 2019, 4:21 PM
dmgk added reviewers: tobik, swills, jlaffaye.Jun 24 2019, 4:22 PM
tobik added inline comments.Jun 25 2019, 5:53 AM
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
1150–1151

"the Go port selected via GO_PORT" or similar

1150–1151

"A build dependency"

1157

s/run time dependency/runtime dependency/ or just "run dependency" on whatever is in GO_PORT.

1232–1233

Should be in <warning> or <caution> block.

dmgk updated this revision to Diff 58993.Jun 25 2019, 12:49 PM

Address tobik@ feedback.

Harbormaster completed remote builds in B25024: Diff 58993.Jun 25 2019, 12:49 PM
dmgk marked 3 inline comments as done.Jun 25 2019, 12:51 PM
mat added inline comments.Jun 25 2019, 2:59 PM
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
1232–1233

and s/should not/must not/, or s/should not/cannot/.

dmgk updated this revision to Diff 59001.Jun 25 2019, 3:11 PM

should not -> must not

Harbormaster completed remote builds in B25032: Diff 59001.Jun 25 2019, 3:11 PM
dmgk marked an inline comment as done.Jun 25 2019, 3:11 PM
dmgk marked an inline comment as done.Jun 25 2019, 4:20 PM
mat added inline comments.Jun 26 2019, 11:46 AM
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
1152

maybe

on the Go compiler port
1158–1159

use the <buildtarget> tag for build targets.

1227

Same here

The Go compiler port to use.
1232–1233

Bad formatting, there should be a blank space before the opening of <warning>, and then the <para>tage should be on its own lines.

dmgk updated this revision to Diff 59048.Jun 26 2019, 12:29 PM

Update based on mat@ comments.

Harbormaster completed remote builds in B25052: Diff 59048.Jun 26 2019, 12:29 PM
dmgk marked 4 inline comments as done.Jun 26 2019, 12:30 PM
dmgk retitled this revision from The porter's handbook Go chapter: document build/run args and GO_PORT variable to The porter's handbook Go chapter: document no_targets/run args and GO_PORT variable.
mat accepted this revision.Jun 26 2019, 4:24 PM
This revision is now accepted and ready to land.Jun 26 2019, 4:24 PM
Closed by commit rD53205: Porter's Handbook: Document no_targets/run and GO_PORT after ports r505321 (authored by tobik). · Explain WhyJun 29 2019, 3:57 AM
This revision was automatically updated to reflect the committed changes.
tobik added a commit: rD53205: Porter's Handbook: Document no_targets/run and GO_PORT after ports r505321.

Revision Contents
Changeset List

PathSize
en_US.ISO8859-1/
books/
porters-handbook/
uses/
38 lines

Diff 59048

View Options

en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml

Loading...