Page MenuHomeFreeBSD

Fix bogomips calculation
ClosedPublic

Authored by trasz on Jun 19 2019, 12:50 AM.

Details

Summary

Fix bogomips calculation. Previously it was off by half.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Would be good to put some reference to determining the appropriate bogomips value, either as a comment in the code if there's something reasonable you can link to, or in the commit message if you just found this case by observation (e.g., something like "on the same hardware I noticed that Linux's real bogomips value was twice that that we reported" if that's the case).

It was compared under VMWare Fusion - with the change the value matches what the actual CentOS reports.

Another observation: on my T420 it reports 2491.96, whereas a googled cpuinfo from a real T420 (https://lkml.org/lkml/2011/11/29/116) reports 5182.63.

IMO go ahead and commit, but add a comment referencing your empirical results above

This revision was not accepted when it landed; it landed in state Needs Review.Jul 18 2020, 10:54 AM
This revision was automatically updated to reflect the committed changes.