Silently ignore FS_IOC_FIEMAP - man(1) calls it for no good reason.
Details
Details
- Reviewers
dchagin emaste - Group Reviewers
Linux Emulation - Commits
- rS349750: Return ENOTSUP for Linux FS_IOC_FIEMAP ioctl.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Minor point, I wouldn't call this "silently ignored" - the console message will be gone but we still return error, except a different error.
IMO I would make the commit message headline something like Return ENOTSUP for Linux FS_IOC_FIEMAP ioctl and in the body mention the man(1) issue and the side effect of avoiding the console spam.
| sys/compat/linux/linux_ioctl.c | ||
|---|---|---|
| 3584 ↗ | (On Diff #58777) | aside, this function could use some comments e.g. when this case is expected to be used vs. the handler lists above |