Page MenuHomeFreeBSD

Symplify links installation by using multi variable for loop
ClosedPublic

Authored by bapt on Mar 15 2015, 2:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 27 2023, 3:55 PM
Unknown Object (File)
Dec 27 2023, 7:32 AM
Unknown Object (File)
Dec 20 2023, 12:48 AM
Unknown Object (File)
Aug 12 2023, 2:08 PM
Unknown Object (File)
Aug 1 2023, 2:54 PM
Unknown Object (File)
Aug 1 2023, 2:54 PM
Unknown Object (File)
Aug 1 2023, 2:53 PM
Unknown Object (File)
Aug 1 2023, 2:52 PM
Subscribers

Details

Summary

This not only simplify the code, but also add extra validation if someone by mistake create a macro with only one argument:
He will receive

make: "/usr/src/share/mk/bsd.links.mk" line 10: Wrong number of words (1) in .for substitution list with 2 vars
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/src/etc/pam.d

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bapt retitled this revision from to Symplify links installation by using multi variable for loop.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: imp.

Fix echoing what is happening

imp edited edge metadata.

I don't think fmake allowed the multiple variables, so we used to be stuck with the old code. This is a nice cleanup. We've already cut that cord, so no need to be compatible.

This revision is now accepted and ready to land.Mar 15 2015, 9:34 PM
bapt updated this revision to Diff 4233.

Closed by commit rS280122 (authored by @bapt).