Page MenuHomeFreeBSD

Introduce quirks tunable for da driver
ClosedPublic

Authored by bevan_bi-co.net on Jun 17 2019, 7:41 PM.

Details

Summary

Introduce a tunable kern.cam.da.X.quirks for devices handled by da, similar to that already existing for ada. This simplifies testing quirks for new devices as the kernel does not need to be recompiled.

I used this while trying to fix issues with a misbehaving drive. I don't know if this is something you may want to include, however I thought I'd post it here before it gets lost.

Test Plan

I tested this on FreeBSD 12.0-RELEASE and 13.0-CURRENT by adding the tunable to loader.conf, setting it to a combination of several quirks, and observing the kernel output when loading the corresponding device.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lwhsu added reviewers: mav, imp.Tue, Sep 17, 8:24 PM
mav requested changes to this revision.Tue, Sep 17, 10:04 PM

Generally I think it is good, but I think it should be set higher, after the "softc->quirks |= DA_Q_NO_6_BYTE;" line.

This revision now requires changes to proceed.Tue, Sep 17, 10:04 PM

Thanks for the review! I agree it makes sense to move the code up so that other settings are derived accordingly.

mav accepted this revision.Wed, Sep 18, 7:42 PM
This revision is now accepted and ready to land.Wed, Sep 18, 7:42 PM
This revision was automatically updated to reflect the committed changes.