Use some bmake variable modifier to simplify a bit the code
Not sure people will consider this as an improvement or as obfuscation :)
Details
- Reviewers
- None
- Group Reviewers
portmgr
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 24694 Build 23461: arc lint + arc unit
Event Timeline
I do feel it is really harder to read.
Also, reading make(1), I don't even understand what :? is supposed to be doing:
:?true_string:false_string If the variable name (not its value), when parsed as a .if conditional expression, evaluates to true, return as its value the true_string, otherwise return the false_string.
The "If the variable name (not its value)" makes me feel it kinda means ${FOO:?a:b} is equivalent to
.if FOO a .else b .endif
Which does not make much sense to me because I figure it is always true.
"it is more" is a bit too vague to be really helpful ;-)
I think that bit of the man page should be rewritten, with an exact example of what it does, because if someone like me that writes a lot of make(1) code do not understand what it does, I do feel we should not be using it...
I think that bit of the man page should be rewritten, with an exact example of what it does, because if someone like me that writes a lot of make(1) code do not understand what it does, I do feel we should not be using it...
I am sure that @sjg would be happy to help here :)