Some of the config options that are disabled by default seem to be only
for historical reasons. Enable those that appear to no longer be
problematic. This includes WITH_CTF, STACK, and re-enabling blacklisted
kernel modules.
Details
Details
- Reviewers
br markj - Commits
- rS348839: RISC-V: Clean up some GENERIC options
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/riscv/conf/GENERIC | ||
|---|---|---|
| 54 ↗ | (On Diff #58156) | Yeah, there's no real separation. I've been confused by that before and it would be nice to fix. OTOH there is code that is conditional on STACK and not STACK || DDB, so I think it would be best to keep it enabled. |
| 55 ↗ | (On Diff #58156) | Any idea why it was disabled? Do we now build successfully with GEOM_RAID configured? I would leave it enabled if we build and boot successfully, if only for consistency with other configs. If not, just remove it. All of that functionality is available as a loadable module as far as I know. |
| sys/riscv/conf/GENERIC | ||
|---|---|---|
| 55 ↗ | (On Diff #58156) | No idea. It was like that for the initial RISC-V commit. It builds and boots fine so I will re-enable it. |
| sys/riscv/conf/GENERIC | ||
|---|---|---|
| 29 ↗ | (On Diff #58156) | This line was here as a quick way to disable modules build to dramatically speed up a local build when you don't need modules. If you prefer to remove this line, then I am fine with this. |
| 55 ↗ | (On Diff #58156) | I don't remember. It could be that it was not building with GEOM_RAID enabled initially. |