Differential D2031

Reduce the machine specific parts of the efi loader
ClosedPublic
Actions

Authored by andrew on Mar 8 2015, 7:40 PM.

Details

Reviewers

emaste
imp

Commits

rS280351: Stop calling x86_efi_copyin and x86_efi_getdev directly. This is to help

Summary

This moves from calling x86_efi_copyin and x86_efi_getdev directly
to use their functions pointers in archsw.

It also fixes the type used to round addresses to u_long as this is
the type used in subr_modules.c in the kernel.

Test Plan

Run on an amd64 efi system. I don't have a setup to test these.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

andrew updated this revision to Diff 4150.Mar 8 2015, 7:40 PM

andrew retitled this revision from to Reduce the machine specific parts of the efi loader.

andrew updated this object.

andrew edited the test plan for this revision. (Show Details)

andrew added a reviewer: emaste.

Herald added a subscriber: imp. · View Herald TranscriptMar 8 2015, 7:40 PM

This looks good to my eye.

Why do you need the change?

This revision is now accepted and ready to land.Mar 8 2015, 8:54 PM

In D2031#4, @imp wrote:

This looks good to my eye.

Why do you need the change?

I'm trying to merge my changes to port loader.efi to 32-bit arm. I would like to merge this back in as much as possible as it could then be moved to a common location.

Closed by commit rS280351 (authored by @andrew).

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

amd64/

efi/

bootinfo.c

26 lines

Diff 4329

View Options

head/sys/boot/amd64/efi/bootinfo.c

Reduce the machine specific parts of the efi loaderClosedPublicActions