Differential D20201

Put other CPUs into tight loop when updating microcode from loaded OS.
ClosedPublic
Actions

Authored by kib on May 8 2019, 6:54 PM.

Details

Reviewers

emaste
markj

Commits

rS347368: x86: Put other CPUs into tight loop when updating Intel microcode from

Summary

This should prevent at least some theoretical issues whith code execution on HT sibling of the core where the update is loaded.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.May 8 2019, 6:54 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 8 2019, 6:54 PM

Harbormaster completed remote builds in B24158: Diff 57193.May 8 2019, 6:54 PM

markj added inline comments.May 8 2019, 7:18 PM

sys/dev/cpuctl/cpuctl.c
387 ↗	(On Diff #57193)	I believe you can simply pass NULL instead of null_st for the same effect.

kib marked an inline comment as done.May 8 2019, 7:43 PM

kib added inline comments.

sys/dev/cpuctl/cpuctl.c
387 ↗	(On Diff #57193)	Ah yes, smp_rendezvous() requires special value, not NULL, to skip spinning.

Simplify.

Harbormaster completed remote builds in B24162: Diff 57197.May 8 2019, 7:44 PM

markj accepted this revision.May 8 2019, 7:48 PM

This revision is now accepted and ready to land.May 8 2019, 7:48 PM

Closed by commit rS347368: x86: Put other CPUs into tight loop when updating Intel microcode from (authored by kib). · Explain WhyMay 8 2019, 8:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

cpuctl/

cpuctl.c

26 lines

Diff 57198

View Options

head/sys/dev/cpuctl/cpuctl.c

Put other CPUs into tight loop when updating microcode from loaded OS.ClosedPublicActions