Page MenuHomeFreeBSD
Differential D20121

Optimize padding in powerpc busdma_machdep.c
ClosedPublic
Actions

Authored by bdragon on May 1 2019, 4:14 AM.
Tags
Referenced Files
F107394170: D20121.diff
Mon, Jan 13, 1:27 PM
F107353218: D20121.id56896.diff
Sun, Jan 12, 10:28 PM
Unknown Object (File)
Sat, Jan 4, 11:39 PM
Unknown Object (File)
Fri, Dec 27, 11:23 PM
Unknown Object (File)
Thu, Dec 26, 8:21 PM
Unknown Object (File)
Sep 18 2024, 5:13 AM
Unknown Object (File)
Sep 17 2024, 5:43 PM
Unknown Object (File)
Sep 1 2024, 8:32 PM
View All 30 Files
Subscribers
imp

Details

Reviewers
jhibbits
Commits
rS347079: powerpc: Optimize padding in bus_dma_tag
Summary

Noticed this while manually inspecting DMA tags.

Save 64 bytes of padding (32b after nsegments due to alignment requirements of next member, 32b after map_count due to alignment requirements of next member due to odd number of contig. ints.)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bdragon created this revision.May 1 2019, 4:14 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 1 2019, 4:14 AM
jhibbits accepted this revision.May 1 2019, 2:10 PM

From my count it saves 8 bytes, not 64. I don't think it's a significant issue, given the size of the structure already, but it's not a bad change, and does allow for better packing.

This revision is now accepted and ready to land.May 1 2019, 2:10 PM
bdragon added a comment.May 1 2019, 6:02 PM

Yeah I meant bits, not bytes. 64 bits. 8 bytes.

Closed by commit rS347079: powerpc: Optimize padding in bus_dma_tag (authored by jhibbits). · Explain WhyMay 4 2019, 2:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
powerpc/
powerpc/
2 lines

Diff 56896

View Options

sys/powerpc/powerpc/busdma_machdep.c

Loading...