Differential D20121

Optimize padding in powerpc busdma_machdep.c
ClosedPublic
Actions

Authored by bdragon on May 1 2019, 4:14 AM.

Tags

Referenced Files

	Unknown Object (File)
	Wed, Mar 25, 2:59 AM

	Unknown Object (File)
	Tue, Mar 24, 4:52 PM

	Unknown Object (File)
	Tue, Mar 24, 12:20 AM

	Unknown Object (File)
	Tue, Mar 24, 12:07 AM

	Unknown Object (File)
	Sat, Mar 21, 10:54 PM

	Unknown Object (File)
	Tue, Mar 17, 3:21 AM

	Unknown Object (File)
	Mon, Mar 16, 11:34 PM

	Unknown Object (File)
	Mon, Mar 16, 2:38 AM

View All 83 Files

Subscribers

imp

Details

Reviewers

jhibbits

Commits

rS347079: powerpc: Optimize padding in bus_dma_tag

Summary

Noticed this while manually inspecting DMA tags.

Save 64 bytes of padding (32b after nsegments due to alignment requirements of next member, 32b after map_count due to alignment requirements of next member due to odd number of contig. ints.)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdragon created this revision.May 1 2019, 4:14 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 1 2019, 4:14 AM

From my count it saves 8 bytes, not 64. I don't think it's a significant issue, given the size of the structure already, but it's not a bad change, and does allow for better packing.

This revision is now accepted and ready to land.May 1 2019, 2:10 PM

Yeah I meant bits, not bytes. 64 bits. 8 bytes.

Closed by commit rS347079: powerpc: Optimize padding in bus_dma_tag (authored by jhibbits). · Explain WhyMay 4 2019, 2:45 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

powerpc/

busdma_machdep.c

2 lines

Diff 57029

View Options

head/sys/powerpc/powerpc/busdma_machdep.c

Optimize padding in powerpc busdma_machdep.cClosedPublicActions