Paths

Table of Contentst

Differential D20118

Fix erroneous assert in libzfs diff
ClosedPublic
Actions

Authored by freqlabs on May 1 2019, 1:05 AM.

Tags

None

Referenced Files

	F171812555: D20118.id56893.diff
	Sun, Sep 13, 5:49 PM

	F171790382: D20118.id61413.diff
	Sun, Sep 13, 1:23 PM

	F171789307: D20118.diff
	Sun, Sep 13, 1:13 PM

	F171714920: D20118.id61413.diff
	Sat, Sep 12, 11:20 PM

	Unknown Object (File)
	Sat, Sep 12, 6:17 PM

	Unknown Object (File)
	Sat, Sep 12, 4:26 PM

	Unknown Object (File)
	Fri, Sep 11, 9:39 PM

	Unknown Object (File)
	Thu, Sep 10, 8:33 AM

View All Files

Subscribers

delphij

imp

Details

Reviewers

mav

Commits

rS351574: MFV/ZoL: Fix wrong assertion in libzfs diff error handling

Summary

All of the error cases in differ() set di->zerr to EPIPE so it doesn't make sense to assert that the error is EINVAL. If an error is set, assert it is EPIPE.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

freqlabs created this revision.May 1 2019, 1:05 AM

Herald added subscribers: delphij, imp. · View Herald TranscriptMay 1 2019, 1:05 AM

ZoL commit: https://github.com/zfsonlinux/zfs/commit/9dc41a769df164875d974c2431b2453e70e16c41

freqlabs retitled this revision from Fix erronious assert in libzfs diff to Fix erroneous assert in libzfs diff.Aug 28 2019, 1:35 PM

mav accepted this revision.Aug 28 2019, 4:57 PM

This revision is now accepted and ready to land.Aug 28 2019, 4:57 PM

Closed by commit rS351574: MFV/ZoL: Fix wrong assertion in libzfs diff error handling (authored by mav). · Explain WhyAug 28 2019, 5:39 PM

This revision was automatically updated to reflect the committed changes.

mav added a commit: rS351574: MFV/ZoL: Fix wrong assertion in libzfs diff error handling.

Revision Contents
Changeset List

Path

Size

head/

cddl/

contrib/

opensolaris/

lib/

libzfs/

common/

libzfs_diff.c

2 lines

Diff 61413

View Options

head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_diff.c

Fix erroneous assert in libzfs diffClosedPublicActions