Differential D20102

Use fls to avoid a loop in isqrt
ClosedPublic
Actions

Authored by dougm on Apr 30 2019, 6:12 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 26, 9:30 PM

	Unknown Object (File)
	Sun, Apr 26, 12:22 PM

	Unknown Object (File)
	Tue, Apr 21, 8:18 AM

	Unknown Object (File)
	Tue, Apr 21, 8:18 AM

	Unknown Object (File)
	Mon, Apr 20, 7:39 AM

	Unknown Object (File)
	Mon, Apr 20, 7:08 AM

	Unknown Object (File)
	Apr 12 2026, 7:50 PM

	Unknown Object (File)
	Apr 2 2026, 4:09 PM

View All 95 Files

Subscribers

imp

Details

Reviewers

markj
kib

Commits

rS347043: fls() should find the most significant bit of an int faster than a

Summary

fls() should find the most significant bit of an int faster than a linear search can, so use it to avoid a linear search in isqrt.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm created this revision.Apr 30 2019, 6:12 AM

kib accepted this revision.Apr 30 2019, 10:52 AM

This revision is now accepted and ready to land.Apr 30 2019, 10:52 AM

markj accepted this revision.Apr 30 2019, 2:17 PM

Closed by commit rS347043: fls() should find the most significant bit of an int faster than a (authored by dougm). · Explain WhyMay 3 2019, 2:56 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMay 3 2019, 2:56 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_pageout.c

4 lines

Diff 56989

View Options

Use fls to avoid a loop in isqrtClosedPublicActions