Differential D20045

GPIO 32 bit access support for Mediatek and gpioc bug fix
AbandonedPublic
Actions

Authored by yamori813_yahoo.co.jp on Apr 25 2019, 3:40 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 4, 3:56 AM

	Unknown Object (File)
	Fri, Sep 4, 3:15 AM

	Unknown Object (File)
	Fri, Sep 4, 2:53 AM

	Unknown Object (File)
	Thu, Sep 3, 8:26 PM

	Unknown Object (File)
	Wed, Sep 2, 3:43 AM

	Unknown Object (File)
	Wed, Sep 2, 3:39 AM

	Unknown Object (File)
	Wed, Sep 2, 3:03 AM

	Unknown Object (File)
	Thu, Aug 27, 3:34 PM

View All Files

Subscribers

loos

Details

Reviewers

sgalabov
mizhka
adrian
• ian
imp

Summary

GPIO 32 bit access support for Mediatek and gpioc bug fix

Include is bug fix.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237378

Test Plan

RT5350 and RT3050 by mruby

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23884
Build 22812: arc lint + arc unit

Event Timeline

yamori813_yahoo.co.jp created this revision.Apr 25 2019, 3:40 AM

Herald added a subscriber: loos. · View Herald TranscriptApr 25 2019, 3:40 AM

Harbormaster completed remote builds in B23884: Diff 56624.Apr 25 2019, 3:40 AM

• ian accepted this revision.Apr 25 2019, 10:33 PM

• ian added inline comments.

sys/dev/gpio/gpioc.c
195	I already committed this fix as r346713.
sys/mips/mediatek/mtk_gpio_v1.c
546	I think this should probably be return (err). If you agree, just say so and I'll commit it that way (no need to upload a new diff).

This revision is now accepted and ready to land.Apr 25 2019, 10:33 PM

yamori813_yahoo.co.jp abandoned this revision.Nov 1 2021, 7:24 AM

yamori813_yahoo.co.jp added inline comments.

sys/mips/mediatek/mtk_gpio_v1.c
546	OK. Thanks.

Revision Contents
Changeset List

Path

Size

sys/

dev/

gpio/

gpioc.c

2 lines

mips/

mediatek/

mtk_gpio_v1.c

48 lines

Diff 56624

View Options

sys/dev/gpio/gpioc.c