Differential D20010

Ensure java options are utilized
ClosedPublic
Actions

Authored by zleslie on Apr 22 2019, 4:15 PM.

Details

Reviewers

swills
mat
romain

Commits

rP500514: Ensure java options are utilized

Summary

Without this change, the doc for the rc script references the ability pass Java opts to the start command, but those references are never used. Here we ensure that thse options are respected and implemented.

Test Plan

Poudriere testport with manual execution of starting the daemon.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 23821
Build 22761: arc lint + arc unit

Event Timeline

zleslie created this revision.Apr 22 2019, 4:15 PM

Harbormaster completed remote builds in B23821: Diff 56492.Apr 22 2019, 4:15 PM

LGTM

This revision is now accepted and ready to land.Apr 23 2019, 4:46 PM

Original poster of https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237295 noted that the same issue affects puppetdb. I guess we can address this issue in the same batch of fixes.

This revision now requires changes to proceed.Apr 24 2019, 8:05 AM

Hah, that sounds likely. I'll get this updated.

Update java options in PuppetDB ports

Harbormaster completed remote builds in B23962: Diff 56785.Apr 28 2019, 5:04 PM

I've added the puppetdb ports to this diff. Ready for review.

LGTM! Thanks for handling this!

This revision is now accepted and ready to land.Apr 28 2019, 8:52 PM

mat accepted this revision.Apr 30 2019, 2:17 PM

Closed by commit rP500514: Ensure java options are utilized (authored by zleslie). · Explain WhyApr 30 2019, 6:12 PM

This revision was automatically updated to reflect the committed changes.

zleslie mentioned this in rP500514: Ensure java options are utilized.