Differential D19829

Write string constant differently to improve readability.
ClosedPublic
Actions

Authored by delphij on Apr 5 2019, 6:45 AM.

Tags

None

Referenced Files

	F124981433: D19829.diff
	Sat, Aug 2, 1:09 AM

	Unknown Object (File)
	Sat, Jul 5, 10:45 PM

	Unknown Object (File)
	Sat, Jul 5, 1:07 AM

	Unknown Object (File)
	Jun 29 2025, 1:39 PM

	Unknown Object (File)
	Jun 24 2025, 9:34 AM

	Unknown Object (File)
	Jun 16 2025, 1:24 PM

	Unknown Object (File)
	Jun 15 2025, 6:36 PM

	Unknown Object (File)
	Jun 13 2025, 10:48 PM

View All 76 Files

Subscribers

emaste

imp

Details

Reviewers

rgrimes
kevlo
pgj
emaste

Commits

rS345976: Write string constant differently to improve readability.

Summary

Write string constant differently to improve readability.

Test Plan

test with previous test cases

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij created this revision.Apr 5 2019, 6:45 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 5 2019, 6:45 AM

Harbormaster completed remote builds in B23532: Diff 55833.Apr 5 2019, 6:45 AM

Thank you, that is 100x clearer as to what is in the constant

This revision is now accepted and ready to land.Apr 5 2019, 8:15 AM

This LGTM as long as compilers or static analyzers don't try to "helpfully" warn that the string does not fit or will not be null terminated.

Closed by commit rS345976: Write string constant differently to improve readability. (authored by delphij). · Explain WhyApr 6 2019, 3:42 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sbin/

fsck_msdosfs/

dir.c

6 lines

Diff 55873

View Options

head/sbin/fsck_msdosfs/dir.c

Write string constant differently to improve readability.ClosedPublicActions