Page MenuHomeFreeBSD
Differential D19775

Fix PLIC number of devices supported
ClosedPublic
Actions

Authored by br on Apr 1 2019, 2:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 23, 11:57 AM
Unknown Object (File)
Mon, Mar 23, 7:50 AM
Unknown Object (File)
Mon, Mar 23, 7:50 AM
Unknown Object (File)
Thu, Mar 19, 11:34 PM
Unknown Object (File)
Tue, Mar 17, 5:13 AM
Unknown Object (File)
Mon, Mar 16, 2:49 PM
Unknown Object (File)
Sat, Mar 14, 9:56 PM
Unknown Object (File)
Fri, Mar 13, 8:28 PM
View All Files
Subscribers
imp

Details

Reviewers
markj
mhorne
Commits
rS345796: o Grab the number of devices supported by PLIC from FDT.
Summary
  1. Grab number of devices supported from FDT
  2. Fix bug PLIC_ENABLE macro
Test Plan

Tested on HiFive Unleashed

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

br created this revision.Apr 1 2019, 2:51 PM
markj accepted this revision.Apr 1 2019, 7:43 PM

Looks ok to me other than the comment.

sys/riscv/riscv/plic.c
205 ↗(On Diff #55673)

Should you verify that ndev < PLIC_MAX_IRQS?

This revision is now accepted and ready to land.Apr 1 2019, 7:43 PM
Closed by commit rS345796: o Grab the number of devices supported by PLIC from FDT. (authored by br). · Explain WhyApr 2 2019, 12:02 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptApr 2 2019, 12:02 PM

Revision Contents
Changeset List

PathSize
head/
sys/
riscv/
riscv/
28 lines

Diff 55720

View Options

head/sys/riscv/riscv/plic.c

Loading...