Differential D19694

Change all kernel C-type macros into static inline functions
ClosedPublic
Actions

Authored by • hselasky on Mar 24 2019, 3:29 PM.

Details

Reviewers

kib
imp

Commits

rS345944: MFC r345499:
rS345943: MFC r345499:
rS345942: MFC r345499:
rS345941: MFC r345499:
rS345499: Change all kernel C-type macros into static inline functions.

Summary

The current kernel C-type macros might obscurely hide the fact that the input argument might be used multiple times.

This breaks code like:
isalpha(*ptr++)

The fix is to use static inline functions.

Sponsored by: Mellanox Technologies
MFC after: 1 week

Test Plan

https://github.com/FreeBSDDesktop/kms-drm/issues/138

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• hselasky created this revision.Mar 24 2019, 3:29 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 24 2019, 3:29 PM

Harbormaster completed remote builds in B23275: Diff 55406.Mar 24 2019, 3:29 PM

• hselasky added a reviewer: imp.Mar 24 2019, 3:30 PM

Please update revision description (commit message) to indicate that the change is only made to the kernel ctype.h.

I think it would slightly improve compatibility with old compilers if you use __inline instead of inline. I believe we do not support c89/gnuc89 for kernel for quite long time.

sys/sys/ctype.h
83 ↗	(On Diff #55406)	There is no reason to not fill the line to end, neither to follow tradition and split line before (instead of after) the binary operator.

val_packett.cool added a subscriber: val_packett.cool.Mar 24 2019, 4:05 PM

• hselasky updated this revision to Diff 55412.Mar 24 2019, 8:00 PM

• hselasky retitled this revision from Change all C-type macros into static inline functions to Change all kernel C-type macros into static inline functions.

• hselasky edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B23277: Diff 55412.Mar 24 2019, 8:00 PM

kib accepted this revision.Mar 24 2019, 8:39 PM

This revision is now accepted and ready to land.Mar 24 2019, 8:39 PM

Closed by commit rS345499: Change all kernel C-type macros into static inline functions. (authored by • hselasky). · Explain WhyMar 25 2019, 1:50 PM

This revision was automatically updated to reflect the committed changes.