Page MenuHomeFreeBSD

Don't check if the dataset is mounted when destroying a snapshot (libbe)
ClosedPublic

Authored by rew on Mar 19 2019, 9:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 14, 9:16 AM
Unknown Object (File)
Mon, May 11, 6:10 PM
Unknown Object (File)
Mon, May 11, 3:27 PM
Unknown Object (File)
Mon, May 11, 3:20 PM
Unknown Object (File)
Sun, May 10, 10:33 AM
Unknown Object (File)
Fri, May 8, 7:48 PM
Unknown Object (File)
Thu, May 7, 12:09 PM
Unknown Object (File)
Mon, May 4, 10:54 AM
Subscribers

Details

Summary

This is for bug 236043: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236043

'be_destroy' can destroy a boot environment (by name) or a given snapshot. If the target to be destroyed is
a dataset, check if it's mounted. We don't want to check if the origin dataset is mounted when destroying a snapshot.

Test Plan

$ bectl create bootenv

should produce no errors
$ bectl destroy -o bootenv

Should I include tests for bectl into this revision?

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Change is good; please do go ahead and include a bectl test, referencing the PR in the test's descr.

This revision is now accepted and ready to land.Mar 26 2019, 2:53 AM

Updating D19650: Don't check if the dataset is mounted when destroying a snapshot (libbe)

  • add bectl test for PR 236043
This revision now requires review to proceed.Mar 30 2019, 7:51 PM

Excellent, thanks! Will commit when I get a chunk of free time tomorrow night (for reference, ~22 hours from now)

This revision is now accepted and ready to land.Mar 31 2019, 3:56 AM
This revision was automatically updated to reflect the committed changes.