Page MenuHomeFreeBSD

Don't check if the dataset is mounted when destroying a snapshot (libbe)
ClosedPublic

Authored by rew on Mar 19 2019, 9:18 PM.
Tags
None
Referenced Files
F163642909: D19650.id.diff
Sat, Jul 25, 3:02 AM
Unknown Object (File)
Wed, Jul 22, 11:58 PM
Unknown Object (File)
Wed, Jul 22, 4:39 PM
Unknown Object (File)
Tue, Jul 21, 7:40 PM
Unknown Object (File)
Tue, Jul 21, 8:02 AM
Unknown Object (File)
Mon, Jul 20, 10:53 PM
Unknown Object (File)
Fri, Jul 17, 8:22 AM
Unknown Object (File)
Fri, Jul 17, 5:42 AM
Subscribers

Details

Summary

This is for bug 236043: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236043

'be_destroy' can destroy a boot environment (by name) or a given snapshot. If the target to be destroyed is
a dataset, check if it's mounted. We don't want to check if the origin dataset is mounted when destroying a snapshot.

Test Plan

$ bectl create bootenv

should produce no errors
$ bectl destroy -o bootenv

Should I include tests for bectl into this revision?

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Change is good; please do go ahead and include a bectl test, referencing the PR in the test's descr.

This revision is now accepted and ready to land.Mar 26 2019, 2:53 AM

Updating D19650: Don't check if the dataset is mounted when destroying a snapshot (libbe)

  • add bectl test for PR 236043
This revision now requires review to proceed.Mar 30 2019, 7:51 PM

Excellent, thanks! Will commit when I get a chunk of free time tomorrow night (for reference, ~22 hours from now)

This revision is now accepted and ready to land.Mar 31 2019, 3:56 AM
This revision was automatically updated to reflect the committed changes.