Page MenuHomeFreeBSD
Differential D19616

Uses/qt.mk: Clean-up checks for Qt4.
ClosedPublic
Actions

Authored by rakuco on Mar 17 2019, 8:55 PM.
Tags
None
Referenced Files
F81669138: D19616.diff
Fri, Apr 19, 5:14 PM
Unknown Object (File)
Thu, Apr 18, 10:55 PM
Unknown Object (File)
Mar 12 2024, 8:31 PM
Unknown Object (File)
Mar 12 2024, 8:31 PM
Unknown Object (File)
Mar 12 2024, 8:29 PM
Unknown Object (File)
Feb 22 2024, 5:58 PM
Unknown Object (File)
Feb 6 2024, 4:54 PM
Unknown Object (File)
Feb 5 2024, 3:28 PM
View All 22 Files
Subscribers
mat
tcberner

Details

Reviewers
tcberner
Group Reviewers
kde
O5: Ports Framework(Owns No Changed Paths)
portmgr
Commits
rP496200: Uses/qt.mk: Clean-up checks for Qt4
Summary

Remove a few Qt4-only blocks, and simplify others by leaving only the else case.

Test Plan

make build-depends-list and make -V LIB_DEPENDS worked fine in ports like devel/qt5-testlib and x11-fm/dolphin.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23150
Build 22201: arc lint + arc unit

Event Timeline

rakuco created this revision.Mar 17 2019, 8:55 PM
Owners added a reviewer: O5: Ports Framework.Mar 17 2019, 8:55 PM
Herald added a reviewer: portmgr. · View Herald TranscriptMar 17 2019, 8:55 PM
Herald added a subscriber: mat. · View Herald Transcript
Harbormaster completed remote builds in B23150: Diff 55176.Mar 17 2019, 8:55 PM
Harbormaster completed remote builds in B23150: Diff 55176.
mat accepted this revision as: O5: Ports Framework, portmgr.Mar 17 2019, 9:35 PM

(approving this as portmgr so that phabricator does not gives you grief.)

tcberner accepted this revision.Mar 18 2019, 5:19 AM
tcberner added a subscriber: tcberner.

Looks good to me too.

This revision is now accepted and ready to land.Mar 18 2019, 5:19 AM
Closed by commit rP496200: Uses/qt.mk: Clean-up checks for Qt4 (authored by rakuco). · Explain WhyMar 18 2019, 8:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Mk/
Uses/
19 lines

Diff 55176

View Options

Mk/Uses/qt.mk

Loading...