Page MenuHomeFreeBSD
Differential D19595

sgx: Don't attach if EPC data is corrupted.
ClosedPublic
Actions

Authored by kd on Mar 15 2019, 4:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 30, 1:03 PM
Unknown Object (File)
Tue, Sep 30, 7:31 AM
Unknown Object (File)
Tue, Sep 30, 5:39 AM
Unknown Object (File)
Tue, Sep 30, 4:11 AM
Unknown Object (File)
Sun, Sep 28, 3:56 PM
Unknown Object (File)
Sun, Sep 28, 3:20 PM
Unknown Object (File)
Sun, Sep 28, 10:00 AM
Unknown Object (File)
Fri, Sep 26, 6:33 AM
View All 93 Files
Subscribers
imp

Details

Reviewers
br
mw
mst_semihalf.com
Commits
rS345288: Prevent loading SGX with incorrect EPC data
Summary

On my machine even if sgx is disabled in firmware the driver still tries to attach with EPS base and size equal to zeroes.
Such behavior results in kernel panic when the module is unloaded.
This is probably caused by a crappy firmware.
Add a simple check to make sure that those values are not zeroes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kd created this revision.Mar 15 2019, 4:21 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 15 2019, 4:21 PM
br accepted this revision.Mar 15 2019, 4:33 PM
This revision is now accepted and ready to land.Mar 15 2019, 4:33 PM
Closed by commit rS345288: Prevent loading SGX with incorrect EPC data (authored by mw). · Explain WhyMar 19 2019, 2:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
sgx/
6 lines

Diff 55219

View Options

head/sys/amd64/sgx/sgx.c

Loading...