Page MenuHomeFreeBSD

sysutils/xen-tools: remove docs option
AcceptedPublic

Authored by royger on Mar 15 2019, 10:20 AM.

Details

Reviewers
bapt
mat
novel
Summary

Manpages should always be installed.

Requested by: mat
Sponsored by: Citrix Systems R&D

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23109
Build 22164: arc lint + arc unit

Event Timeline

royger created this revision.Mar 15 2019, 10:20 AM
royger edited the summary of this revision. (Show Details)Mar 15 2019, 10:22 AM
mat added a comment.Mar 15 2019, 11:01 AM

What happened to all the html files in DOCSDIR?

In D19592#419471, @mat wrote:

What happened to all the html files in DOCSDIR?

The install-docs target doesn't seem to install them anymore. In fact I think I prefer to use the specific man-pages and install-man-pages targets, or else other documentation might get generated and installed if the user for example has pandoc installed. Let me prepare a new version.

Note that the easiest way to access those docs is using http://xenbits.xen.org/docs/4.11-testing/ IMO.

royger updated this revision to Diff 55103.Mar 15 2019, 11:45 AM
  • Use a explicit target to only build man pages, instead of using the generic docs target and expecting only the man pages to be built.
  • Remove the markdown dependency, the html files can be easily fetched from https://xenbits.xen.org/docs/.
novel accepted this revision.Mar 15 2019, 4:15 PM

This change looks good to me. It looks like this port needs some more improvements though, e.g. stripping installed binaries.

This revision is now accepted and ready to land.Mar 15 2019, 4:15 PM