Page MenuHomeFreeBSD

Porter's Handbook: Update USES=cmake description
ClosedPublic

Authored by tobik on Mar 13 2019, 5:44 AM.

Details

Summary
  • outsource is no longer a valid argument
  • Document noninja, insource

Diff Detail

Repository
rD FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tobik created this revision.Mar 13 2019, 5:44 AM
tcberner accepted this revision.Mar 13 2019, 6:59 AM
tcberner added a subscriber: tcberner.

Thank you. I should really update these things too when changing it...

en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
3230 ↗(On Diff #55008)

^ that is a todo for me: update s/4/5

mat accepted this revision.Mar 13 2019, 7:30 AM

Looks ok to me, maybe s/:4/:5/ as Tobias said as :4 is already half gone.

This revision is now accepted and ready to land.Mar 13 2019, 7:30 AM
tobik added a comment.Mar 13 2019, 7:49 AM

Thank you both for the quick review.

In D19567#418837, @mat wrote:

Looks ok to me, maybe s/:4/:5/ as Tobias said as :4 is already half gone.

I may look at this later. I think Qt 4/KDE 4 in the handbook should all go away in one separate change. It's also not that simple since the USE_KDE, USE_QT components in the examples are no longer valid with :5, there are more places where Qt 4 is mentioned, and there is no mention or list of any KDE 5 components in the entire handbook yet AFAICT.

This revision was automatically updated to reflect the committed changes.