Page MenuHomeFreeBSD

Check sanity of CMAKE helpers relative to USES
ClosedPublic

Authored by adridg on Mar 9 2019, 8:40 PM.
Tags
None
Referenced Files
F172751165: D19525.id54886.diff
Sun, Sep 20, 6:06 PM
Unknown Object (File)
Thu, Sep 17, 5:50 AM
Unknown Object (File)
Aug 21 2026, 5:58 PM
Unknown Object (File)
Aug 21 2026, 3:22 PM
Unknown Object (File)
Aug 20 2026, 3:59 PM
Unknown Object (File)
Aug 19 2026, 2:12 AM
Unknown Object (File)
Aug 18 2026, 11:49 PM
Unknown Object (File)
Aug 12 2026, 8:32 AM
Subscribers

Details

Summary

If a CMAKE helper is used (e.g. CMAKE_ARGS, or <foo>_CMAKE_ON)
then that only makes sense if cmake is actually used (i.e. is in
USES).

Test Plan

Run against audio/fmit, in r488406 and in HEAD.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Dunno why I had bdrewery in mind here.

ports-mgmt/portlint/src/portlint.pl
1793 ↗(On Diff #54886)

That's an unrelated typo-fix.

1814 ↗(On Diff #54886)

@tcberner suggests that an OPTION shouldn't switch the build system, so this checking may not be needed, which would simplify things a bit.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2019, 12:09 PM
This revision was automatically updated to reflect the committed changes.