Page MenuHomeFreeBSD
Differential D19525

Check sanity of CMAKE helpers relative to USES
ClosedPublic
Actions

Authored by adridg on Mar 9 2019, 8:40 PM.
Tags
None
Referenced Files
F160415202: D19525.id55836.diff
Wed, Jun 24, 6:39 AM
Unknown Object (File)
Thu, Jun 18, 7:53 AM
Unknown Object (File)
Wed, Jun 17, 10:13 AM
Unknown Object (File)
Wed, Jun 17, 2:54 AM
Unknown Object (File)
Tue, Jun 16, 9:58 AM
Unknown Object (File)
Thu, Jun 4, 7:49 PM
Unknown Object (File)
May 6 2026, 12:57 PM
Unknown Object (File)
May 4 2026, 2:51 PM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
yuri
marcus
Commits
rP497950: Add check for sensible CMAKE settings to ports-mgmt/portlint
Summary

If a CMAKE helper is used (e.g. CMAKE_ARGS, or <foo>_CMAKE_ON)
then that only makes sense if cmake is actually used (i.e. is in
USES).

Test Plan

Run against audio/fmit, in r488406 and in HEAD.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adridg created this revision.Mar 9 2019, 8:40 PM
Herald added a subscriber: mat. · View Herald TranscriptMar 9 2019, 8:40 PM
Harbormaster completed remote builds in B22981: Diff 54886.Mar 9 2019, 8:40 PM
adridg edited reviewers, added: marcus; removed: bdrewery.Mar 9 2019, 8:43 PM

Dunno why I had bdrewery in mind here.

adridg added inline comments.Mar 9 2019, 8:45 PM
ports-mgmt/portlint/src/portlint.pl
1793 ↗(On Diff #54886)

That's an unrelated typo-fix.

1814 ↗(On Diff #54886)

@tcberner suggests that an OPTION shouldn't switch the build system, so this checking may not be needed, which would simplify things a bit.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2019, 12:09 PM
Closed by commit rP497950: Add check for sensible CMAKE settings to ports-mgmt/portlint (authored by adridg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
ports-mgmt/
portlint/
2 lines
src/
13 lines

Diff 55836

View Options

head/ports-mgmt/portlint/Makefile

Loading...
View Options

head/ports-mgmt/portlint/src/portlint.pl

Loading...