Page MenuHomeFreeBSD

Check sanity of CMAKE helpers relative to USES
ClosedPublic

Authored by adridg on Mar 9 2019, 8:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 1:15 AM
Unknown Object (File)
Tue, Apr 16, 1:15 AM
Unknown Object (File)
Tue, Apr 16, 1:15 AM
Unknown Object (File)
Tue, Apr 9, 12:46 PM
Unknown Object (File)
Mar 1 2024, 6:55 AM
Unknown Object (File)
Jan 25 2024, 11:36 AM
Unknown Object (File)
Jan 25 2024, 11:36 AM
Unknown Object (File)
Jan 25 2024, 11:35 AM
Subscribers

Details

Summary

If a CMAKE helper is used (e.g. CMAKE_ARGS, or <foo>_CMAKE_ON)
then that only makes sense if cmake is actually used (i.e. is in
USES).

Test Plan

Run against audio/fmit, in r488406 and in HEAD.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Dunno why I had bdrewery in mind here.

ports-mgmt/portlint/src/portlint.pl
1793 ↗(On Diff #54886)

That's an unrelated typo-fix.

1814 ↗(On Diff #54886)

@tcberner suggests that an OPTION shouldn't switch the build system, so this checking may not be needed, which would simplify things a bit.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2019, 12:09 PM
This revision was automatically updated to reflect the committed changes.