Page MenuHomeFreeBSD

Check sanity of CMAKE helpers relative to USES
ClosedPublic

Authored by adridg on Mar 9 2019, 8:40 PM.

Details

Summary

If a CMAKE helper is used (e.g. CMAKE_ARGS, or <foo>_CMAKE_ON)
then that only makes sense if cmake is actually used (i.e. is in
USES).

Test Plan

Run against audio/fmit, in r488406 and in HEAD.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

adridg created this revision.Mar 9 2019, 8:40 PM
adridg edited reviewers, added: marcus; removed: bdrewery.Mar 9 2019, 8:43 PM

Dunno why I had bdrewery in mind here.

adridg added inline comments.Mar 9 2019, 8:45 PM
ports-mgmt/portlint/src/portlint.pl
1793 ↗(On Diff #54886)

That's an unrelated typo-fix.

1814 ↗(On Diff #54886)

@tcberner suggests that an OPTION shouldn't switch the build system, so this checking may not be needed, which would simplify things a bit.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2019, 12:09 PM
This revision was automatically updated to reflect the committed changes.