Differential D19521

sysutils/xen-tools: fix plist when DOCS option is disabled
ClosedPublic
Actions

Authored by novel on Mar 9 2019, 1:18 PM.

Details

Reviewers

royger

Commits

rP495459: sysutils/xen-tools: fix plist when DOCS option is disabled

Summary

Fix plist when DOCS option is disabled
Install man pages into a proper directory and also get them compressed

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

novel created this revision.Mar 9 2019, 1:18 PM

Herald added a subscriber: mat. · View Herald TranscriptMar 9 2019, 1:18 PM

LGTM, thanks!

This revision is now accepted and ready to land.Mar 11 2019, 4:31 PM

Forgot to ask but can you commit this?

I'm not a ports committer myself, so I would have to ask for your 'Approved by' if I have to commit this, which seems quite pointless.

Closed by commit rP495459: sysutils/xen-tools: fix plist when DOCS option is disabled (authored by novel). · Explain WhyMar 12 2019, 3:09 PM

This revision was automatically updated to reflect the committed changes.

The manpages should not be behind the DOCS option, they should either always be installed, or be behind a MANPAGES option (that defaults to on).

In D19521#418756, @mat wrote:

The manpages should not be behind the DOCS option, they should either always be installed, or be behind a MANPAGES option (that defaults to on).

Thanks, let me see if I can find some time to fix this either today or tomorrow.

In D19521#418909, @royger wrote:

In D19521#418756, @mat wrote:

The manpages should not be behind the DOCS option, they should either always be installed, or be behind a MANPAGES option (that defaults to on).

Thanks, let me see if I can find some time to fix this either today or tomorrow.