- Ports using cargo vendor and the like aren't covered
Details
- Reviewers
tobik - Group Reviewers
rust O5: Ports Framework portmgr - Commits
- rP494175: USES=cargo to update libc to 0.2.49 for Tier2
Not yet. Waiting for Rust 1.33.0 next week to save time.
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
This looks ok to me.
Ports using cargo vendor and the like aren't covered
I switched graphics/librsvg2-rust over to libc-0.2.49 in rP493676. We could probably do the same with net-im/fractal.
How many ports are there that do this (ignoring the Gecko ports) after that?
Only security/suricata as security/kr is marked BROKEN. www/cliqz contains Gecko but isn't based on USE_GECKO.
$ comm -23 rust.all.list rust.uses-cargo.list graphics/librsvg2-rust mail/thunderbird net-im/fractal security/kr security/suricata www/cliqz www/firefox www/firefox-esr www/seamonkey
mail/thunderbird
www/cliqz
www/firefox
www/firefox-esr
Fixed by rP494312. Updating whole libc either via huge patch or Mk/bsd.gecko.mk hackery was more risky and required a lot of work for essentially one patch.
security/suricata
Fixed by rP495041 (has libc-0.2.50 now).
net-im/fractal
Fixed in rP495652 by copying www/firefox-esr/files/patch-bug1530098. Less work and easier to prune on update.
Thank you for fixing the rest of them.
In rP495652 I don't understand why you update .cargo-checksum.json with new checksums when you could just replace it with
{"files":{},"package":"76e3a3ef172f1a0b9a9ff0dd1491ae5e6c948b94479a3021819ba7d860c8645d"}
in patch-no-x86. Same in the Gecko ports. This isn't any more hacky than updating .cargo-checksum.json with new checksums, reduces the patch size considerably, and doesn't require extra tools beyond sed -i.orig -e 's/"files":{[^}]*}/"files":{}/' .cargo-checksum.json
For consistency with other patches under net-im/fractal/files/. All of those are supposed to go away on the next update.