Page MenuHomeFreeBSD
Differential D19263

Document the efivar --load-option option
ClosedPublic
Actions

Authored by bcran on Feb 20 2019, 5:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 1:35 AM
Unknown Object (File)
Fri, Nov 1, 4:38 AM
Unknown Object (File)
Oct 18 2024, 8:28 PM
Unknown Object (File)
Oct 18 2024, 10:39 AM
Unknown Object (File)
Oct 3 2024, 1:15 PM
Unknown Object (File)
Oct 2 2024, 6:34 PM
Unknown Object (File)
Oct 1 2024, 1:46 PM
Unknown Object (File)
Sep 27 2024, 5:42 PM
View All 79 Files
Subscribers
bcran

Details

Reviewers
imp
kevans
Group Reviewers
manpages
Commits
rS344862: Document the efivar --load-option option

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bcran created this revision.Feb 20 2019, 5:22 AM
Harbormaster completed remote builds in B22603: Diff 54120.Feb 20 2019, 5:22 AM
bcran added a reviewer: manpages.Feb 20 2019, 5:23 AM
bcran updated this revision to Diff 54121.Feb 20 2019, 5:26 AM
  • Remove text about needing to use --print with --load-option
Harbormaster completed remote builds in B22604: Diff 54121.Feb 20 2019, 5:26 AM
bcran updated this revision to Diff 54122.Feb 20 2019, 5:26 AM

Fix review

Harbormaster completed remote builds in B22605: Diff 54122.Feb 20 2019, 5:26 AM
bcran updated this revision to Diff 54123.Feb 20 2019, 5:27 AM

.

Harbormaster completed remote builds in B22606: Diff 54123.Feb 20 2019, 5:27 AM
kevans accepted this revision.Mar 5 2019, 4:02 AM
kevans added inline comments.
usr.sbin/efivar/efivar.8
152–153 ↗(On Diff #54123)

I might suggest re-wording slightly to more strongly indicate that the value will be fully decoded into its path components rather than displayed as-is. I don't feel that strongly about it, though.

This revision is now accepted and ready to land.Mar 5 2019, 4:02 AM
imp added inline comments.Mar 5 2019, 6:22 AM
usr.sbin/efivar/efivar.8
152–153 ↗(On Diff #54123)

I'd be inclined for something more verbose:

"Decode the variable as if it were a UEFI BOOT_OPTION, including information about what device and/or paths the UEFI DEVICE_PATHS decode to"

But I'm not sure that's quite right either.

bcran added a subscriber: bcran.Mar 5 2019, 7:24 AM

I like that idea. Except perhaps write BOOT_OPTION as Boot Option.

Closed by commit rS344862: Document the efivar --load-option option (authored by bcran). · Explain WhyMar 7 2019, 12:01 AM
This revision was automatically updated to reflect the committed changes.
bcran marked 2 inline comments as done.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
efivar/
7 lines

Diff 54791

View Options

head/usr.sbin/efivar/efivar.8

Loading...