Page MenuHomeFreeBSD
Differential D19214

Fix refcount leak in SGX Linux compat ioctl handlers.
ClosedPublic
Actions

Authored by markj on Feb 16 2019, 6:31 PM.
Tags
None
Referenced Files
F151449857: D19214.diff
Wed, Apr 8, 11:55 AM
F151373682: D19214.diff
Tue, Apr 7, 11:28 PM
Unknown Object (File)
Fri, Apr 3, 7:08 AM
Unknown Object (File)
Thu, Apr 2, 12:18 PM
Unknown Object (File)
Thu, Apr 2, 4:03 AM
Unknown Object (File)
Wed, Apr 1, 12:21 PM
Unknown Object (File)
Thu, Mar 26, 1:27 AM
Unknown Object (File)
Tue, Mar 24, 6:50 AM
View All Files
Subscribers
imp

Details

Reviewers
br
kib
Commits
rS344232: Fix refcount leaks in the SGX Linux compat ioctl handler.
Summary

Also get rid of some debug prints while here.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Feb 16 2019, 6:31 PM
Harbormaster completed remote builds in B22530: Diff 53991.Feb 16 2019, 6:31 PM
markj updated this revision to Diff 53992.Feb 16 2019, 6:37 PM
  • Return the error from copyin(9).
Harbormaster completed remote builds in B22531: Diff 53992.Feb 16 2019, 6:37 PM
markj added reviewers: br, kib.Feb 16 2019, 6:38 PM
kib accepted this revision.Feb 16 2019, 8:26 PM
kib added inline comments.
sys/amd64/sgx/sgx_linux.c
84 ↗(On Diff #53992)

Fix style there as well ? (!= 0)

This revision is now accepted and ready to land.Feb 16 2019, 8:26 PM
Closed by commit rS344232: Fix refcount leaks in the SGX Linux compat ioctl handler. (authored by markj). · Explain WhyFeb 17 2019, 4:44 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2019, 4:44 PM

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
sgx/
22 lines

Diff 54016

View Options

head/sys/amd64/sgx/sgx_linux.c

Loading...