Differential D19207

security/pam_krb5: Update to 4.8
ClosedPublic
Actions

Authored by woodsb02 on Feb 16 2019, 4:01 AM.

Details

Reviewers

Commits

rP493710: Update 4.7 --> 4.8
rP493709: Pet portlint.
rP493708: Add LICENSE details.

Summary

security/pam_krb5: Update to 4.8

Add LICENSE details
Pet portlint (Makefile order)

Approved by: cy (maintainer)

Test Plan

poudriere testport success on 13amd64
Runtime testing also worked fine

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 22522
Build 21668: arc lint + arc unit

Event Timeline

woodsb02 created this revision.Feb 16 2019, 4:01 AM

Herald added a subscriber: mat. · View Herald TranscriptFeb 16 2019, 4:01 AM

Harbormaster completed remote builds in B22522: Diff 53982.Feb 16 2019, 4:02 AM

Looks good except the update, license and portlint changes need to be three separate commits. I will approve if you keep the three functional commits separate, clean easy to follow logs.

security/pam_krb5/Makefile
5	Separate commit, please.
16	Separate commit, please.

This revision now requires changes to proceed.Feb 16 2019, 4:57 AM

mat added inline comments.Feb 20 2019, 4:01 PM

security/pam_krb5/Makefile
28	That variable is not a framework variable, so it should go after the options, see Chapter 15. Order of Variables in Port Makefiles. That being said, it is also never used, so it should probably be removed.