Page MenuHomeFreeBSD

bhyve(8) block_if.c remove multiple freeing of nopt added in r340042
ClosedPublic

Authored by rgrimes on Feb 14 2019, 7:28 PM.

Details

Summary

In r340042 an attempt to quiet coverity warning cid 1305412 was overdone.
nopt is the only allocated space, xopt and cp are aliases into that allocated space.

Remove the 2 unneeded free's

Brought to my attention by Patrick Mooney of Joyent/illumos

Test Plan

Visual code inspection.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rgrimes created this revision.Feb 14 2019, 7:28 PM

This is the fix we're applying to SmartOS bhyve, after syncing from upstream.

jhb accepted this revision.Feb 14 2019, 7:37 PM
This revision is now accepted and ready to land.Feb 14 2019, 7:37 PM
This revision was automatically updated to reflect the committed changes.