Page MenuHomeFreeBSD

vmxnet3: add native netmap support
ClosedPublic

Authored by g.lettieri_iet.unipi.it on Feb 7 2019, 1:32 PM.

Details

Summary

Sunnyvalley, Inc., is sponsoring native netmap support for the vmxnet3 adapter. This comes for free in 12, since the driver has been ported to iflib. This patch adds native support for 11 in the legacy way. To make it minimally intrusive, the native support is only enabled if vmxnet3.netmap_native is set at boot.

Tested on stable-11 running inside vmplayer.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vmaffione added a comment.EditedFeb 7 2019, 2:06 PM

It would probably help to have more lines of contexts for the patch.
If you used git, you should probably use something like:

git diff -U30 [...]

If you used svn

svn diff -x '-U30'

This is the same patch as before, but with more context added.

vmaffione added inline comments.Feb 7 2019, 2:51 PM
sys/dev/vmware/vmxnet3/vmx_netmap.h
48 ↗(On Diff #53654)

nm_prdis

249 ↗(On Diff #53654)

nm_prlim()

335 ↗(On Diff #53654)

this can be removed, because netmap_attach_ext already logs "netmap queues/slots" using if_printf.

replaced old debug macros and removed a useless log message.

vmaffione accepted this revision.Feb 18 2019, 2:11 PM
vmaffione added inline comments.
sys/dev/vmware/vmxnet3/if_vmx.c
2137 ↗(On Diff #53659)

Can you please break this long line? Second level indents are four spaces, see style(9)

This revision is now accepted and ready to land.Feb 18 2019, 2:11 PM
This revision now requires review to proceed.Feb 18 2019, 4:14 PM
vmaffione accepted this revision.Feb 18 2019, 4:14 PM
This revision is now accepted and ready to land.Feb 18 2019, 4:14 PM
bryanv accepted this revision.Feb 18 2019, 6:52 PM
This revision was automatically updated to reflect the committed changes.