Page MenuHomeFreeBSD

vmxnet3: add native netmap support
ClosedPublic

Authored by g.lettieri_iet.unipi.it on Feb 7 2019, 1:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 18, 6:50 AM
Unknown Object (File)
Feb 11 2024, 5:39 PM
Unknown Object (File)
Feb 2 2024, 2:43 PM
Unknown Object (File)
Dec 20 2023, 2:48 AM
Unknown Object (File)
Dec 13 2023, 5:20 PM
Unknown Object (File)
Nov 28 2023, 1:59 PM
Unknown Object (File)
Nov 25 2023, 8:20 PM
Unknown Object (File)
Nov 25 2023, 6:20 PM
Subscribers

Details

Summary

Sunnyvalley, Inc., is sponsoring native netmap support for the vmxnet3 adapter. This comes for free in 12, since the driver has been ported to iflib. This patch adds native support for 11 in the legacy way. To make it minimally intrusive, the native support is only enabled if vmxnet3.netmap_native is set at boot.

Tested on stable-11 running inside vmplayer.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

It would probably help to have more lines of contexts for the patch.
If you used git, you should probably use something like:

git diff -U30 [...]

If you used svn

svn diff -x '-U30'

This is the same patch as before, but with more context added.

sys/dev/vmware/vmxnet3/vmx_netmap.h
48 ↗(On Diff #53654)

nm_prdis

249 ↗(On Diff #53654)

nm_prlim()

335 ↗(On Diff #53654)

this can be removed, because netmap_attach_ext already logs "netmap queues/slots" using if_printf.

replaced old debug macros and removed a useless log message.

vmaffione added inline comments.
sys/dev/vmware/vmxnet3/if_vmx.c
2137 ↗(On Diff #53659)

Can you please break this long line? Second level indents are four spaces, see style(9)

This revision is now accepted and ready to land.Feb 18 2019, 2:11 PM
This revision now requires review to proceed.Feb 18 2019, 4:14 PM
This revision is now accepted and ready to land.Feb 18 2019, 4:14 PM
This revision was automatically updated to reflect the committed changes.