Page MenuHomeFreeBSD

ifconfig: fix endianness bug displaying pfsync interfaces
ClosedPublic

Authored by asomers on Jan 28 2019, 4:48 PM.

Details

Summary

ifconfig: fix endianness bug displaying pfsync interfaces

Test Plan

ifconfig tun0 create
kldload pfsync
ifconfig pfsync syncdev tun0
ifconfig pfsync0 # Verify that peer address doesn't display

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

asomers created this revision.Jan 28 2019, 4:48 PM
kristof added inline comments.
sbin/ifconfig/ifpfsync.c
198 ↗(On Diff #53316)

I think that needs to be 'htonl()'.

It'll work of course, but INADDR_PFSYNC_GROUP is in host byte order, and preq.pfsyncr_syncpeer.s_addr is in network order, so you want to go from host to network order, and not the other way around.

asomers added inline comments.Jan 28 2019, 5:23 PM
sbin/ifconfig/ifpfsync.c
198 ↗(On Diff #53316)

Oh, my mistake. I saw the definition and read it as a byte array, ignoring the leading (in_addr_t)

#define INADDR_PFSYNC_GROUP     ((in_addr_t)0xe00000f0) /* 224.0.0.240 */
asomers updated this revision to Diff 53324.Jan 28 2019, 5:24 PM

s/ntohl/htonl

kristof accepted this revision.Jan 28 2019, 5:44 PM
This revision is now accepted and ready to land.Jan 28 2019, 5:44 PM
This revision was automatically updated to reflect the committed changes.