Fix quotas for UFS after r339008
ClosedPublic
Actions

Authored by sef on Jan 8 2019, 7:56 PM.

Tags

None

Referenced Files

	F103354554: D18785.id52674.diff
	Sat, Nov 23, 11:17 PM

	Unknown Object (File)
	Sat, Nov 23, 2:10 AM

	Unknown Object (File)
	Fri, Nov 22, 8:18 PM

	Unknown Object (File)
	Fri, Nov 22, 6:10 PM

	Unknown Object (File)
	Fri, Nov 22, 11:49 AM

	Unknown Object (File)
	Thu, Nov 21, 11:34 AM

	Unknown Object (File)
	Thu, Nov 21, 2:29 AM

	Unknown Object (File)
	Wed, Nov 20, 3:04 PM

View All Files

Subscribers

imp

Details

Reviewers

mav
delphij

Commits

rS343882: r343881 had an uninitialized error. This fixes that.
rS343881: r339008 broke repquota for UFS. This rectifies that.

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233849 reported by Andre Albsmeier, that my change to expose ZFS quotas broke repquota for UFS.

This refactors the code in libutil/quotafile.c a bit so that repquota works again.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sef created this revision.Jan 8 2019, 7:56 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 8 2019, 7:56 PM

sef added a reviewer: delphij.Feb 7 2019, 8:48 PM

It looks like a workaround on workaround, but considering it is deep legacy, so be it.

This revision is now accepted and ready to land.Feb 7 2019, 8:59 PM

delphij accepted this revision.Feb 7 2019, 9:37 PM

Closed by commit rS343881: r339008 broke repquota for UFS. This rectifies that. (authored by sef). · Explain WhyFeb 7 2019, 9:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libutil/

quotafile.c

17 lines

Diff 53672

View Options

head/lib/libutil/quotafile.c

Fix quotas for UFS after r339008ClosedPublicActions