Page MenuHomeFreeBSD
Differential D18784

readelf(1): Decode values when DT_FLAGS/DT_FLAGS_1
ClosedPublic
Actions

Authored by borako.ozarslan_gmail.com on Jan 8 2019, 6:26 PM.
Tags
None
Referenced Files
F107141795: D18784.id52673.diff
Fri, Jan 10, 6:36 PM
F107141792: D18784.id52676.diff
Fri, Jan 10, 6:36 PM
F107141788: D18784.id52696.diff
Fri, Jan 10, 6:36 PM
F107141786: D18784.id53444.diff
Fri, Jan 10, 6:36 PM
F107141784: D18784.id.diff
Fri, Jan 10, 6:36 PM
Unknown Object (File)
Fri, Jan 10, 4:05 PM
Unknown Object (File)
Fri, Jan 3, 10:35 PM
Unknown Object (File)
Thu, Jan 2, 3:24 AM
View All Files
Subscribers
imp
jkoshy_users.sourceforge.net
kaiw

Details

Reviewers
emaste
Commits
rS343592: readelf: decode flag bits in DT_FLAGS/DT_FLAGS_1
Summary

Decode d_val when the tag is DT_FLAGS or DT_FLAGS_1 based on the information at:

https://docs.oracle.com/cd/E23824_01/html/819-0690/chapter6-42444.html

PR: 232983
Submitted by: Bora Ozarslan borako.ozarslan@gmail.com

Test Plan

Compile a trivial program using the command cc -Wl,-z,now main.c and use readelf -d a.out on it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

borako.ozarslan_gmail.com created this revision.Jan 8 2019, 6:26 PM
emaste added subscribers: kaiw, jkoshy_users.sourceforge.net.Jan 8 2019, 7:23 PM
emaste added inline comments.Jan 8 2019, 7:53 PM
contrib/elftoolchain/readelf/readelf.c
297–298 ↗(On Diff #52673)

should be in alpha order - i.e., before dump_dyn_val

emaste added inline comments.Jan 8 2019, 7:55 PM
contrib/elftoolchain/readelf/readelf.c
2852 ↗(On Diff #52673)

Why print "Flags:" for flags_1 and no prefix for flags above?

borako.ozarslan_gmail.com updated this revision to Diff 52676.Jan 8 2019, 9:55 PM
borako.ozarslan_gmail.com added inline comments.
contrib/elftoolchain/readelf/readelf.c
2852 ↗(On Diff #52673)

That's the behavior in GNU readelf as seen in the bug report

borako.ozarslan_gmail.com updated this revision to Diff 52696.Jan 9 2019, 3:55 PM
borako.ozarslan_gmail.com marked an inline comment as done.
borako.ozarslan_gmail.com marked an inline comment as done.
emaste accepted this revision.Jan 9 2019, 4:55 PM
This revision is now accepted and ready to land.Jan 9 2019, 4:55 PM
Closed by commit rS343592: readelf: decode flag bits in DT_FLAGS/DT_FLAGS_1 (authored by emaste). · Explain WhyJan 30 2019, 8:44 PM
This revision was automatically updated to reflect the committed changes.
emaste added inline comments.Jan 30 2019, 8:44 PM
contrib/elftoolchain/readelf/readelf.c
2852 ↗(On Diff #52696)

FreeBSD style(9) has a space between if and (. Will update prior to commit.

Herald added a subscriber: imp. · View Herald TranscriptJan 30 2019, 8:45 PM
dim mentioned this in rS367466: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 11:58 PM

Revision Contents
Changeset List

PathSize
head/
contrib/
elftoolchain/
readelf/
140 lines

Diff 53444

View Options

head/contrib/elftoolchain/readelf/readelf.c

Loading...